Subject: Re: Null pointer dereference of cmd_name in shell.c
From: lazuse
Date: Mon, 01 Jun 2020 17:21:52 +0000
Hi,

Thanks for the quick fix. Actually I first sent the bug report 5 days ago, but it seems that the mail never reached your inbox. Maybe you should check your mail server, as the MX server for megous.com (i.e., vps.xff.cz) is currently NXDOMAIN.

Best Regards


Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, June 1, 2020 12:07 AM, Ondřej Jirman <megatools@megous.com> wrote:

> Hi,
>
> On Sun, May 31, 2020 at 02:32:37PM +0000, lazuse wrote:
>
> > Hello,
> > In "tools/shell.c", line 63, pointer "cmd_name" will be dereferenced as NULL
> > unless it is set in Line 59 when argv[0] is prefixed with "mega". Now,
> > megatools crashes if ran as something like "a.out".
>
> Thanks for the bugreport. :)
>
> regards,
> o.
>
> > Please consider wrapping Line 62-65 with "if (cmd_name != NULL)".